This is my day i guess as everyone is asking questions i have answers for.
Anyhow, I have used surplus Army PT (Physical Training) shorts for all three of my Long Distance hikes.
They are cheap, about 6 bucks at the army surplus store.
They are light, and dry very quickly. In fact i simply took a shower in them while in town and walked them dry on the way to breakfast.
They have their own "underwear" liner built right in and i get about 1,000 miles on a pair before the liner begins to wear out.
They only have a small pocket on the right leg used to hold Army I.D.
The pocket is not very useful I am afraid.
They have a simple drawcord at the waist and i like the fact that they are so simply constructed there is nothing to chafe me under my pack hip belt.
Here is a picture of Army PT shorts: